Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependencies to support Storybook >=8.2.0 explicitly #346

Merged
merged 11 commits into from
Oct 31, 2024
Merged

Fix dependencies to support Storybook >=8.2.0 explicitly #346

merged 11 commits into from
Oct 31, 2024

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Oct 31, 2024 •
edited by ghengeveld
Loading

  • Widened range of Storybook dependencies and peerDependencies to match ^8.0.0 as well as any current and future 8.X prereleases
  • @storybook/channels were only used for types, which we don't publish any of, so it became a devDependency
  • @storybook/types were mainly used for types too, except for Addon_TypesEnum in the manager, but in the manager @storybook/types is globalized, so it can be a devDependency
  • @storybook/core-events and @storybook/telemetry are properly used in the preset, so we have to depend on them.
  • All the internally used Storybook's where changed from a canary to the 8.4.0 beta. I've vetted that they aren't actually used in the package but only in this repository's Storybook, except for the ones mentioned above.
📦 Published PR as canary version: 3.2.2--canary.346.1e6e793.0

✨ Test out this PR locally via:

npm install @chromatic-com/[email protected]
# or 
yarn add @chromatic-com/[email protected]

@JReinhold JReinhold self-assigned this Oct 31, 2024
@JReinhold JReinhold requested a review from ghengeveld October 31, 2024 10:21
@JReinhold JReinhold added patch Auto: Increment the patch version when merged dependencies Pull requests that update a dependency file release Auto: Create a `latest` release when merged labels Oct 31, 2024
ghengeveld
ghengeveld approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@JReinhold
Copy link
Contributor Author

I've manually QA'd this:

  • confirmed the canary works in 8.2, 8.3 and 8.4 (fantastic to see the UI change over time here 👏)
  • confirmed npm throws a peer dep error if you try this in an 8.1 project
  • confirmed, as expected, that if you try 8.1. anyway with --legacy-peer-deps, Storybook will throw a hard error.

@JReinhold JReinhold marked this pull request as ready for review October 31, 2024 21:23
@JReinhold JReinhold changed the title Fix dependencies to support Storybook >8.0.0 explicitly Fix dependencies to support Storybook >8.2.0 explicitly Oct 31, 2024
@JReinhold JReinhold changed the title Fix dependencies to support Storybook >8.2.0 explicitly Fix dependencies to support Storybook >=8.2.0 explicitly Oct 31, 2024
@JReinhold JReinhold merged commit 0d5a793 into main Oct 31, 2024
8 checks passed
@JReinhold JReinhold deleted the fix-dependencies branch October 31, 2024 21:57
@ghengeveld
Copy link
Member

🚀 PR was released in v3.2.2 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghengeveld ghengeveld ghengeveld approved these changes

Assignees

@JReinhold JReinhold

Labels
dependencies Pull requests that update a dependency file patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JReinhold @ghengeveld